Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Sunbeam storage backend implementation for ProphetStor (DPL FC) and integrates it into the existing backend test suite and fixtures.
Changes:
- Introduce
ProphetstorBackendandProphetstorConfigundersunbeam.storage.backends.prophetstor. - Add unit tests for the ProphetStor backend and extend shared backend tests to include it.
- Update pytest fixtures to provide a
prophetstor_backendand include it in the parametrizedany_backendfixture.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sunbeam-python/sunbeam/storage/backends/prophetstor/backend.py | Adds the ProphetStor backend class and its Pydantic config model. |
| sunbeam-python/sunbeam/storage/backends/prophetstor/init.py | Declares the ProphetStor backend package. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_prophetstor.py | Adds backend-specific tests for ProphetStor config/type behavior. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py | Extends shared “all backends” tests to include ProphetStor expectations. |
| sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py | Adds the ProphetStor fixture and includes it in the parametrized backend fixture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-prophetstor-charm
branch
from
f0a65e3 to
496d720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/984510